Ale: Rubocop syntax error displayed as warning instead of error

[jayniz]

When a ruby file contains a syntax error, all other linter warnings are not displayed anymore, and the line with the error is displayed with the warning signs:

The corresponding error message is:

Unexpected token tIDENTIFIER (Using Ruby 2.3 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)

Is this a bug or expected behavior?

[w0rp]

I think it just shows all messages as warnings. Someone will need to have a look at the linter and figure out some way to show some messages as errors, and some as warnings. Or perhaps all messages should be errors. If someone knows Ruby better than I do, they can have a look.

[jayniz]

@w0rp actually - other things are displayed as errors by rubocop, I believe. If we remove the line with the invalid syntax from the example above, it looks like this:

[jayniz]

P.S. I just complained about a bug and forgot to first thank you for making ale. It's super useful, so here is a big thank you! 🎉

[w0rp]

I like complaining. Complaining is the first step towards fixing anything.

[kriansa]

It seems that Rubocop returns an E error code for syntax errors, but rubocop#Handle expects for C as an error. (https://github.com/w0rp/ale/blob/master/ale_linters/ruby/rubocop.vim#L29).

Changing this line to

        \   'type': index(['C', 'E'], l:type) != -1 ? 'E' : 'W',

Fixes the issue.

[w0rp]

I have pushed that line as a fix for this now.