Alasql: check for options.cache missing in exec

Created on 12 Feb 2020 · 7Comments · Source: agershun/alasql

I have noticed that https://github.com/agershun/alasql/blob/a725fec8943b6dce391ebff6a7258ab45205c5c3/dist/alasql.js#L4642 has a check for alasql.options.cache before it adds a statement to the cache but the line at https://github.com/agershun/alasql/blob/a725fec8943b6dce391ebff6a7258ab45205c5c3/dist/alasql.js#L11566 doesnt. Is there a reason why the check is not there in exec but is there in dexec? This is important as I am trying to reduce the RAM footprint when using ALASQL in a production environment

! Question

Source

umasudhan

All 7 comments

Hi @umasudhan. Thank you for looking into this. Its very likely that we missed a detail there. Im traveling at the moment so cant dig into the details.

You are more than welcome to suggest exactly where we should add a check so we can make the library better.

mathiasrw on 12 Feb 2020

Thanks Mathias- will submit a patch

umasudhan on 13 Feb 2020

❤1

Hi @mathiasrw have uploaded the patch- please advise if you would prefer a PR instead. Thanks!

check_if_cache_is_enabled_before_caching_statement.patch.txt

umasudhan on 17 Feb 2020

I would really love a PR - Then the contribution is also credited correct :)

mathiasrw on 18 Feb 2020

hi Matthias,
I am unable to push to a branch I created of develop- I get a 403. Do I need some token/permission to do this?
Thanks

umasudhan on 20 Feb 2020

Hi @umasudhan

Have you forked the repo?

Please have a look at https://github.com/agershun/alasql/blob/develop/.github/CONTRIBUTING.md

mathiasrw on 22 Mar 2020

HI Mathias
Apologies- didnt read the readme 🤔
Will follow the process.
Thanks
Uma

On Sun, Mar 22, 2020 at 12:56 PM Mathias Rangel Wulff <
[email protected]> wrote:

Hi @umasudhan https://github.com/umasudhan

Have you forked the repo?

Please have a look at
https://github.com/agershun/alasql/blob/develop/.github/CONTRIBUTING.md

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/agershun/alasql/issues/1164#issuecomment-602135374,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZJ7LXAERQCKTSO32P7TALRIVV45ANCNFSM4KTS3HMA
.