Al: Please prevent same name in Globals and Locals
Please let the compiler give an error in this case:
bvbeek
All 10 comments
Or add (at least) CodeCop warning.
IvoMol
on 19 Jul 2018
+1 for CodeCop warning not error.
rdebath
on 19 Jul 2018
I vote for the error. Having global and local vars with the same name is incredibly confusing to read and quite bad form. I've seen it lead to bad logic as well when the wrong variable was being used from what the developer intended.
MikeGlue
on 19 Jul 2018
An example would be in C#, you can save variable name in class level or method level, you can distinguish the scope by using this keyword.
shlemonz
on 19 Jul 2018
Yup fair enough, I just think that it's not a very clean way to write code. I'm actually reworking as much code as I can to eliminate global vars completely :) ….but of course that's not always possible.
MikeGlue
on 19 Jul 2018
I agree, it gets messy...
shlemonz
on 19 Jul 2018
"... eliminate global vars completely ..."
Agreed, the functional style of programming usually helps making things easier to understand. Reducing or eliminating global variables reduces the number of interactions that a function could possibly do by explicitly listing only the variables that a function is allowed to access.
"...reworking..."
This is the issue. While in the theoretical world everything can be converted, in the real world you're waiting on other people (usually Microsoft) to allow the change to be possible.
This reminds me of a feature of other code analysis tools (Inline excuses #2970) with that additional feature it could be reasonable to add a $CodeCop warning for every use of a global variable.
rdebath
on 20 Jul 2018
@rdebath good point!
bvbeek
on 20 Jul 2018
Changing this behaviour will inevitably lead to messy variable names, further impacting readability.
Frantic42
on 22 Oct 2018
Is added as rule AA0198
MarcHansenMicrosoft
on 16 Jan 2020
Related issues
FSharpCSharp
·
3Comments
dkatson
·
3Comments
RedFoxUA
·
3Comments
ghost
·
3Comments
lvanvugt
·
3Comments
Most helpful comment
Agreed, the functional style of programming usually helps making things easier to understand. Reducing or eliminating global variables reduces the number of interactions that a function could possibly do by explicitly listing only the variables that a function is allowed to access.
This is the issue. While in the theoretical world everything can be converted, in the real world you're waiting on other people (usually Microsoft) to allow the change to be possible.
This reminds me of a feature of other code analysis tools (Inline excuses #2970) with that additional feature it could be reasonable to add a
$CodeCopwarning for every use of a global variable.