Aiohttp: Choice of either aio-libs/aiohttp/ or aaugustin/websockets for an unified cryptocurrency Websocket interface (CCXT)

[samholt]

Hi All,

Taking the lead on the Websocket development of the large open source project: https://github.com/ccxt/ccxt.

Would anyone be so kind as to recommend whether we choose either:

• https://github.com/aaugustin/websockets/
• https://github.com/aio-libs/aiohttp/

Which one would be best suited to the task of interfacing with cryptocurrency exchange web sockets ?

(Comments here can go into the eventual projects documentation, detailing the reason for the choice).

Thank you all

[kxepal]

Well, _obliviously_, aiohttp! What else could be recommended you here? (:

I guess if you list your requirement to websocket implementation, API and etc. the answer could be more specific. _Like, definitely aiohttp!_

Beside jokes, quickly looking into websockets project I see it's just a websockets implementation for asyncio. aiohttp is a bit more than websockets - it's a framework to make web applications and other frameworks for the same goal. So picking aiohttp support you will get more than just websockets. However, if you need just websockets as transport and you don't ever plan to provide any integration of your project with aiohttp-based services...well, then aiohttp provides too much redundant features for you.

[samholt]

Great thanks for the quick reply.

Yes aiohttp looks excellent, can aiohttp handle backpressure correctly ?
"
Robustness: websockets is built for production; for example it was the only library to handle backpressure correctly before the issue became widely known in the Python community.
"
(https://github.com/aaugustin/websockets)

[kxepal]

@samholt
Yes. It should be correctly handled.

[samholt]

And keeping connections alive ?
https://websockets.readthedocs.io/en/stable/cheatsheet.html#keeping-connections-open

Your comments are excellent, thank you !

[kxepal]

And yes - we have autoping and heartbeat features to keep connections alive.

[samholt]

Fantastic thank you, we'll be integrating ccxt with aiohttp

[kxepal]

Cool! Don't forget to mention your project in powered by section when you'll done (:

[kxepal]

And feel free to open issues / prs if something will be missed. I guess, this one could be closed now?

[samholt]

Yes, thank you will do

[fafhrd91]

@kxepal good work 👍 :)

[asvetlov]

@kxepal would you upgrade http://aiohttp.readthedocs.io/en/stable/faq.html with a new QA section?

[kxepal]

@fafhrd91 10x (:

@asvetlov Not sure what should I add there?..

[asvetlov]

Just emphasize that we do support websockets with backpressure etc.
aiohttp is the best choice if user needs even websocket server only but it works pretty good if HTTP server is needed too (usually user needs both).

[kxepal]

Ah, ok. Will figure something!

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].