Aiohttp: Nominate Pau Freixes to aiohttp committer

Created on 19 Oct 2017 · 12Comments · Source: aio-libs/aiohttp

@fafhrd91 and I suggest to give @pfreixes write access to the repo.

Hi improved DNS caching very much as well as other minor contributions.
His initiative for client tracing support is amazing.

Let's vote:

-1 for strong objection
+-0 for not sure
+1 for definitely yes

Vote is finishing in a week at 2017-10-26

outdated

Source

asvetlov

Most helpful comment

No, our team is not such big to require 2-3 reviewers.
I don't follow the note about transparency, sorry.

asvetlov on 31 Oct 2017

👍2

All 12 comments

kxepal on 19 Oct 2017

fafhrd91 on 19 Oct 2017

The vote has finished.
I see no objections.

Welcome, @pfreixes

asvetlov on 26 Oct 2017

🎉1

Thanks, I will try to do my best to help you guys!

pfreixes on 26 Oct 2017

👍1

🎉 @pfreixes 🎉

kxepal on 26 Oct 2017

do you have any protocol about the number of reviewers needed to accept a PR?

pfreixes on 31 Oct 2017

I'm not aware about such, but one so far is enough. But you can always call for more if you want to gather more feedback.

May be so project by law would be nice to have to make such processes transparent and clear.

kxepal on 31 Oct 2017

No, our team is not such big to require 2-3 reviewers.
I don't follow the note about transparency, sorry.

asvetlov on 31 Oct 2017

👍2

@asvetlov I was referenced in my mind to document like this that we have in CouchDB. It detaily describe how project processes works. Quite handy for newcomers.

kxepal on 31 Oct 2017

Looks pretty good!
Would you contribute something like this into our documentation?

asvetlov on 31 Oct 2017

welcome @pfreixes.

samuelcolvin on 31 Oct 2017

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].