Aiohttp: 2.0 rc release

[fafhrd91]

what we need to do for 2.0 dev0 release.

original issue https://github.com/fafhrd91/aiohttp/issues/6

@jettify @kxepal @thehesiod @samuelcolvin @arthurdarcet

[samuelcolvin]

happy for you to move aiohttp-devtools to aio-libs if you'd like? I still need to test it properly with master.

Also, can I suggest an "rc" release on github? That way we all know what we're downloading and testing. And it might prompt others to test the latest version of aiohttp

[fafhrd91]

cool, lets move aiohttp-devtools.

I like rc idea

[samuelcolvin]

I'm getting

You don’t have the permission to create repositories on aio-libs

I guess you need to give me permissions

[fafhrd91]

sure

[fafhrd91]

you should have permission

[samuelcolvin]

done, just transferring now.

[fafhrd91]

great

[fafhrd91]

I updated migration.rst, I need someone to review it.

http://aiohttp.readthedocs.io/en/latest/migration.html

[arthurdarcet]

One or two breaking changes could be avoided, and simply be deprecations ; but imo we don't need to worry about that since this is a major release (the (BaseConnector|ClientSession).close methods could return an already-resolved asyncio.Future instead of returning None, this way await session.close() would still work)

I have pushed some minor changes in #1716, other than that, looks good to me

[fafhrd91]

I am not sure, how big is the problem with close().
probably ClientSession.close() could return noop()

[arthurdarcet]

that was one of the breaking change that impacted some of my code, but i think it's perfectly ok to have breaking changes in a major release… Deprecating it first would have been nice, but nothing is forcing people to upgrade to 2.0 immediately so i don't feel like it's required here

[jettify]

As far as I remember @asvetlov made ClientSession.close() coroutine in order to provide better finalisation in future. We did mistake with close method in aiopg.Connection by making it regular function.

@asvetlov could you please review this change.

[fafhrd91]

problem with graceful shutdown is that we can not really do it for session.
session does not track requests, and with new changes all completed responses release connections immediately. so developer needs to close reponses otherwise all connections that are in use can not be gracefully be closed.

[fafhrd91]

added "deprecate_noop" specifically for this case

[fafhrd91]

I prepared release https://github.com/aio-libs/aiohttp/releases/tag/untagged-df01c1c4674fe2267db7

I need help with review. anyone wants to add anything to release text?

[samuelcolvin]

You should add:

""
You can install and test this release with

pip install https://github.com/aio-libs/aiohttp/archive/2.0.0rc0.zip

"""

Installing zips with pip is a little-known feature and much faster and less error prone than installing from the 84 different types of scm uri.

Update: just corrected the url. Not important, but isn't the first rc generally called rc1 not rc0?

[arthurdarcet]

I would suggest using

pip install https://github.com/aio-libs/aiohttp/archive/2.0.0rc0.tar.gz#egg=aiohttp-2.0.0rc0

it helps with subsequent updates

[fafhrd91]

I want to make release on pypi

[fafhrd91]

version is changed

[samuelcolvin]

I just tweaked the release text so the pip command shows up as code.

aiohttp-devtools is currently failing with 2.0 due to problems with aiohttp-debutoolbar, see https://github.com/aio-libs/aiohttp-devtools/pull/45 and https://travis-ci.org/aio-libs/aiohttp-devtools/jobs/211466016

[fafhrd91]

do you think it is reasonable to support two major versions at the same time?

[samuelcolvin]

it's definitely a big pain, might be simpler to just add to the readme "for v < 2 use the previous version"

[fafhrd91]

add dependency aiohttp<2.0

and make new major version with aiohttp>=2.0

[arthurdarcet]

the current version of the devtools is 0.2
=> i think the version should just bump to 0.3 and require aiohttp 2, it's not unreasonable to break things in a v0

[samuelcolvin]

Makes sense, I'll do a patch release 0.2.1 to pin <2, then move everything afterwards to >=2

[fafhrd91]

thanks everybody for help.

[fafhrd91]

I think we ready for release, I just want to wait couple days before making final release

[samuelcolvin]

Sounds good to me, aiohttp-devtools is ready with debugtoolbar switched off by default until it's fixed.

[lock[bot]]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a [new issue] for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that [new issue].