Adguardfilters: google.ee

Created on 2 Mar 2019  Â·  17Comments  Â·  Source: AdguardTeam/AdguardFilters

Issue URL (Annoyance)

https://www.google.ee/search?client=chrome&q=p%C3%BCsit%C3%BChik&sourceid=chrome&ie=UTF-8&oe=UTF-8#cns=1

Comment

Username: @Bushido1

An annoying pop-up "Before you continue

To be consistent with data protection laws, we’re asking you to take a moment to review key points of Google’s Privacy Policy. This isn’t about a change that we’ve made – it’s just a chance to review some key points.

We’ll need you to do this in order to continue using Google services." appears from time to time. Even when I have reviewed this before.

The information below is automatically generated. Do not delete it.

Custom userscripts:
https://cdn.adguard.com/public/Userscripts/AdguardPopupBlocker/2.5/popupblocker.user.js
https://cdn.adguard.com/public/Userscripts/AdguardAssistant/4.2/assistant.user.js

Screenshots


Screenshot 1

Screenshot 1

System configuration

Information | value
--- | ---
Platform: | Win
AdGuard version: | 6.4.1814.4903
Browser: | Opera
AdGuard driver: | WFP
Stealth mode options: | Hide your search queries, Send Do-Not-Track header, Remove X-Client-Data header from HTTP requests, Strip URLs from tracking parameters, Block third-party Authorization header, Self-destructing third-party cookies (30), Block WebRTC, Block Location API, Block Flash, Block Java
Filters: | AdGuard Annoyances,
AdGuard Base,
Adblock Warning Removal List,
Estonian List,
I don't care about cookies,
AdGuard Tracking Protection,
AdGuard Social Media

Cannot reproduce AdGuard for Windows Medium Annoyance

Most helpful comment

google.com,google.ee,google.pl##body > #lb > div[id^="_"][class]
google.com,google.ee,google.pl##div[class][role="dialog"] > #cnsp > div[class][aria-live="polite"]
google.com,google.ee,google.pl###main > #body ~ #footer > div[id] > div[id] > #fbar > .fbar > #cnsi > g-dialog > div[id^="_"][class^=" "]
google.com,google.ee,google.pl###main > #lb > div[class] > div[class*="__"]
google.com,google.ee,google.pl###main > #lb > div[id^="_"][class^=" "]

! Scroll recover:
google.com,google.ee,google.pl#$#html.nsc {overflow-y: visible!important; }
google.com,google.ee,google.pl#$#html:not(.nsc) > body.nsc {position: static!important; overflow-y: visible!important; }

All 17 comments

There should not be any bold parts in my comment. Especially the end of my part of sentence "...appears from time to time. Even when I have reviewed this before.".
This happened due to straight copy/paste.

I can't reproduce. Please upload full saved page.

I can't reproduce. Please upload full saved page.

Please share instructions.

Should see after two weeks if no blocked by scriplet, procedural filtering breaks google images loading (no longer block load images).

@AdamWr "the best" should be click "next", 3-4 times in ":arrow_down:" and accept button.

@Bushido1 Ctrl-S(select complete, or something like that in drop-down menu) and upload it here as ZIP archive.

@Alex-302
ZIP archive.zip

Sorry for the late reply. This file does not contain that popup. Please save HTML+resources.

Try on my file:

Szukaj w Google.zip

google.com,google.ee,google.pl##body > #lb > div[id^="_"][class]
google.com,google.ee,google.pl##div[class][role="dialog"] > #cnsp > div[class][aria-live="polite"]
google.com,google.ee,google.pl###main > #body ~ #footer > div[id] > div[id] > #fbar > .fbar > #cnsi > g-dialog > div[id^="_"][class^=" "]
google.com,google.ee,google.pl###main > #lb > div[class] > div[class*="__"]
google.com,google.ee,google.pl###main > #lb > div[id^="_"][class^=" "]

! Scroll recover:
google.com,google.ee,google.pl#$#html.nsc {overflow-y: visible!important; }
google.com,google.ee,google.pl#$#html:not(.nsc) > body.nsc {position: static!important; overflow-y: visible!important; }

Oh. Better leave these rules in custom filter:)

Oh. Better leave these rules in custom filter:)

Why so?:)

Too generic, has-text() also will not help because i18n on Google pages exsist.

Maybe help detect iframe google consent is better.

@krystian3w How to detect iframe google consent regarding the above pop-up and how to compare has-text() and iframe?

For example:

google.com,google.ee#$#html.nsc { overflow-y: visible !important; }
google.com,google.ee#$#html:not(.nsc) > body.nsc { position: static !important; overflow-y: visible !important; }

google.com,google.ee##jsl > #consent-bump > .widget-consent
google.com,google.ee###main > #lb > div[id^="_"][class] > div[class*="__overlay"]:not([id])
google.com,google.ee###main > #lb > div[id^="_"][class] > div[class*="__"]:has(iframe[src^="https://consent.google.com"])

@krystian3w Like this?
image

Nope, you should copy only "corrected" version https://github.com/AdguardTeam/AdguardFilters/issues/30370#issuecomment-483974028 (devoid of the Polish domain "google.pl" for Google).


I tried minimalize risk hide wrong elements with:

  • [class*="__overlay"] - no hide more than overlays

  • div[class*="__"]:has(iframe[src^="https://consent.google.com"]) - no hide more than div with specific iframe


Maybe a little blinking on homepage & search - no possible faster hide element and detect what should be hidden form my side.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

adguard-bot picture adguard-bot  Â·  4Comments

adguard-bot picture adguard-bot  Â·  3Comments

THEtomaso picture THEtomaso  Â·  3Comments

adguard-bot picture adguard-bot  Â·  4Comments

adguard-bot picture adguard-bot  Â·  3Comments