Adguardfilters: www.theguardian.com - elements reordered

Created on 27 Nov 2018  Â·  9Comments  Â·  Source: AdguardTeam/AdguardFilters

The current rule for the Guardian's "Since you're here…" appeal for support, which appears at the end of articles:

theguardian.com##.content__main-column > .contributions__epic

However, it seems they did some reshuffling, and now the parent element's class is .content__article-body. Here's an example article.

The previous, .content__main-column element is still here, but it's not the immediate parent. I'm not sure why the child combinator (>) was used in the first place instead of a descendant combinator (space).

Screenshot:

Screenshot of the "Since you're here…" appeal for support

Resolved Annoyance

All 9 comments

spaces are ignored, but they have a decorative function / improve readability.

If ID have space you should use backslash before any ID space:

https://codepen.io/anon/pen/aQjeZj

<div id="There are no waves"> 
Waves,
There are no waves
There are no waves
There are no waves
There are no waves
There are no waves
There are no waves
</div>

Waves should be hidden.
#There\ are\ no\ waves { display: none }

Huh? I was talking about descendant combinators inside CSS selectors, whose symbol is a space, and arguing for their use instead of child combinators (">" symbol), which are needlessly specific. In this case:

.content__main-column .contributions__epic
.content__main-column > .contributions__epic

https://www.w3schools.com/cssref/sel_element_gt.asp
https://developer.mozilla.org/en-US/docs/Web/CSS/Child_combinator

It is better to include when adding, even when browsing the site from 3 days, than suddenly discover the subdomain where it will cut too much.

If you can safely remove the child selector, it will be removed.

Ok, I changed it.
Thank you.

@AdamWr this is equal to paywall

Ok, I removed it.

theguardian.com##.site-message--banner.yellow.site-message--membership-prominent should probably be removed as well. It was added in the same commit originally, and it also doesn't seem to be used anymore, as I can't see it in uBlock's logger when I browse the site.

Yes, you are right, I removed it.
Thank you.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

TPS picture TPS  Â·  4Comments

adguard-bot picture adguard-bot  Â·  3Comments

adguard-bot picture adguard-bot  Â·  3Comments

adguard-bot picture adguard-bot  Â·  3Comments

THEtomaso picture THEtomaso  Â·  3Comments