Addons: Deprecate all functions/arguments that should be deprecated in Addons 0.12

Created on 27 Aug 2020  路  5Comments  路  Source: tensorflow/addons

Just a note for deprecation.

  • [x] all custom ops activations, where gelu has been migrated to core TensorFlow.
  • [x] all data_format argument under tensorflow_addons/image.
  • [x] sequential_update for AveragedOptimizerWrapper.

Should we maintain the backward compatibility? /cc @tensorflow/sig-addons-maintainers.

deprecation good first issue help wanted

All 5 comments

I think maintaining backwards compatibility is the preferred route when possible. It may require the function to re-arrange some parameters or fill in defaults, but that can be part of the deprecation warning advising the user to use the core functionality.

can i take this up?

Of course! But probably not now. tf.nn.gelu and tf.keras.layers.MultiHeadAttention will be shipped in TF2.4. We will pin to TF2.4 rc version once it releases so we can deprecate gelu and MultiHeadAttention at that time.

Another thought is that we can bump our major version to 1.0.0. We can finalize our optimizer API consistency in the next major version as well.

https://github.com/tensorflow/addons/issues/2187

@WindQAQ IMO we should refactor the optimizers to be consistent with the new API

Was this page helpful?
0 / 5 - 0 ratings

Related issues

seanpmorgan picture seanpmorgan  路  4Comments

shun-lin picture shun-lin  路  4Comments

maziyarpanahi picture maziyarpanahi  路  3Comments

facaiy picture facaiy  路  3Comments

seanpmorgan picture seanpmorgan  路  3Comments