Addons: Complete typing

Created on 31 Jan 2020  路  7Comments  路  Source: tensorflow/addons

Since python2 support was dropped we've begun typing TFA.

To do this gracefully we excluded several modules which were under active development so as to minimize impact on active PRs. We need to remove those modules from the exclusion list as they become no longer worked on and type them appropriately.

Exclusion list:
https://github.com/tensorflow/addons/blob/master/tools/ci_build/verify/check_typing_info.py#L27-L135

good first issue help wanted style

Most helpful comment

Big thank you to @autoih for many PRs working towards this.

All 7 comments

Big thank you to @autoih for many PRs working towards this.

We need to include this in the contribution guidelines.

LGTM! Can we add a simple example as well? Like a class with the constructor signature only.

For more info about all this:

I opened an issue in the tensorflow repository about the autograph bug:

https://github.com/tensorflow/tensorflow/issues/36462

List of pull requests linked to this issue:

894

925

928

929

931

971

972

975

978

981

995

999

1007

1002

1015

1016

1019

Yay! It's finished! Big thanks to @autoih who worked extra hard on this!

If some people are interested, we want to do the same with autokeras! See the link just above.

Thanks so much for the great contributions @autoih

Was this page helpful?
0 / 5 - 0 ratings