Addons: Drop Python2 support

Created on 6 Dec 2019  路  6Comments  路  Source: tensorflow/addons

TF2.1 will be the last package to support python2. We should follow suit and remove support as well.

Some things that we can change off the top of my head:

  • [x] Removal of __future__ boilerplate
  • [ ] Type checking (to start maybe just for examples)
  • [x] Clean-up build
build

Most helpful comment

Pyupgrade on all python files:

878

879

880

881

882

883

884

885

886

887

I hope the reviewers are very motivated.

All 6 comments

I'd be happy to take care of it. I've done it a few time and I know a lot of tools to make it easier.

Ping me when you'd like to drop support. I suppose it'll be when we drop support for the TF2.1.x branch right? So some time around march/april 2020?

I'd be happy to take care of it. I've done it a few time and I know a lot of tools to make it easier.

Ping me when you'd like to drop support. I suppose it'll be when we drop support for the TF2.1.x branch right? So some time around march/april 2020?

That'd be great, thanks @gabrieldemarmiesse! There are a couple of peculiarities with the build that I can modify separately from the python code updates.

As far as timeline we plan to cut our 0.7 branch and publish before 2020. After that we'll drop support on master so sometime in early January.

also replace

return dict(list(base_config.items()) + list(config.items()))

by

return {**base_config, **config}

Good call, I'm on it.

Pyupgrade on all python files:

878

879

880

881

882

883

884

885

886

887

I hope the reviewers are very motivated.

We can close this issue. We'll make another issue to track the typing of the API.

Was this page helpful?
0 / 5 - 0 ratings