Addons-server: Color selectors in static theme submission wizard have layout issues in RTL

[AlexandraMoga]

STR:

1. Log into Developer Hub and submit a new static theme using the wizard
2. Switch to an RTL locale
3. Observe the text layout for the color selectors

Actual result:
The color selector area does not have the same margins as the LTR locales

Expected result:
Color selector area has the same margins for RTL and LTR

Notes:

• reproduced on AMO-dev, FF58 Win10x64

[wagnerand]

Mentor: @eviljeff

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

[deepanshu-jain1999]

I want to work on this issue.

[eviljeff]

@deepanshu-jain1999 great - this should just be a css fix

[deepanshu-jain1999]

Thanks

On Tue, 24 Apr 2018, 4:03 pm Andrew Williamson, [e-mail]
wrote:

@deepanshu-jain1999 https://github.com/deepanshu-jain1999 great - this
should just be a css fix

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla/addons-server/issues/7783#issuecomment-383884411,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Adum0amySeGwuyxhs702ldGROsAFmaJOks5trv92gaJpZM4Sogbp
.

[deepanshu-jain1999]

It seems in this way on linux .

[eviljeff]

@deepanshu-jain1999 that's the old lightweight theme wizard - the one this issue is about is the new static theme wizard https://addons-dev.allizom.org/en-US/developers/addon/submit/wizard-listed

[deepanshu-jain1999]

Thanks I got it . Actually I am new to open source. So I feel afraid how to do it. Please help me where I will get this issue in project. Is this problem specific to window 10 user because it seems fine on linux

[eviljeff]

@deepanshu-jain1999
The problem isn't OS specific, but is specific to RTL locales (e.g. Arabic, Hebrew, Urdu, etc). I should have linked to one of those pages to demonstrate, e.g. https://addons-dev.allizom.org/ar/developers/addon/submit/wizard-listed

[deepanshu-jain1999]

Thanks I got it. It should be in this style

I have done it on browser . Now I am going to implement it inside project

[deepanshu-jain1999]

When I signup on the project locally it redirect to "refuse to connect ". What am i doing wrong?

[eviljeff]

That's quite a vague error and impossible to debug without more details. If you visit the #amo irc channel we might be able to suggest something.

[deepanshu-jain1999]

Yes I have posted on http://disq.us/p/1s9bdf6

[eviljeff]

Yes I have posted on http://disq.us/p/1s9bdf6

That's not irc... that's a website with a directory listing of irc channels.

[deepanshu-jain1999]

I have solved login problem but I am unable to access page http://olympia.test/en-GB/developers/addon/submit/wizard-listed locally. It does not show "Create a Theme Version" div on http://olympia.test/en-GB/developers/addon/submit/upload-listed

[eviljeff]

ah, yes, it's turned off by default. You can enable it by adding a flag (a "waffle switch") in django admin here: http://olympia.test/admin/models/waffle/switch/ called "allow-static-theme-uploads". It will look something like this:

[deepanshu-jain1999]

Thanks

[caitmuenster]

Hey there @deepanshu-jain1999, how's it going with this issue?

[deepanshu-jain1999]

I am in doubt that how to switch RTL locale

[eviljeff]

I linked the page in RTL local in https://github.com/mozilla/addons-server/issues/7783#issuecomment-386048998

[deepanshu-jain1999]

I create a pull request for this issue. Please review it.

[deepanshu-jain1999]

8463 Fix issue #7783

[AlexandraMoga]

Verified as fixed on AMO-dev with FF60, WIn10x64