Addons-server: Resume link is not underlined anymore and its greyed out when hovering

Created on 2 Feb 2017  路  17Comments  路  Source: mozilla/addons-server

Steps to reproduce:
1.Go to AMO -dev and in _Manage My submissions_ observe add-on in an incomplete state
2.Hover over Resume button

Expected results:
Resume button is blue and underlined while hovering on it

Actual results:
Resume button is greyed out and not underlined while hovering

NOTES:
Not reproducible on Stage
Distance between Resume and Delete buttons is different now

Please see video for the bug:
resumebutton

Hacktoberfest devhub assigned good first bug mentor assigned verified fixed triaged regression

All 17 comments

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

Mentor: @eviljeff

I would like to work on this bug, @eviljeff can you please provide some information to start with this bug?

@lavish205 thanks.
This should be just a css change. I changed the Resume 'link' to actually be a button, which meant it lost some styling. It's specified here https://github.com/mozilla/addons-server/blob/master/static/css/devhub/listing.less#L120:L130 and it might just be a matter of adding something similar to https://github.com/mozilla/addons-server/blob/master/static/css/devhub/listing.less#L163:L165 - might need some trial and error and tinkering in the dev tools first.

@eviljeff What I understand is, I need to add blue color to button.link and add text-decoration: underline for hover property.
can you please tell me color hex for blue that we use?

Hi, can I work on this?

I'm not sure if @lavish205 is currently working on this, if not, sure @apoorvasingh17 go for it!

@EnTeQuAk Thank you :)
Where can I find the guidelines to set up the environment?

Hey, I'm a student at Seneca college learning open source, and I was hoping to work on this bug for my course. If no one else is currently working on it, I'd like to give it a try.

It's been a month so I don't think @apoorvasingh17 is still working on it. So go ahead.

Lots of people are interested but no-one seems to proceed further. Shouldn't be complicated so just shout up when you've got the fix ready.

@16116073 yes you need to start submitting an addon with a listed version and get to the details step

@16116073 yes you need to start submitting an addon with a listed version and get to the details step

@eviljeff please review the pr #7231 regarding this issue.

Verified as fixed :
resumeunderlined

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hwine picture hwine  路  7Comments

eviljeff picture eviljeff  路  3Comments

jvillalobos picture jvillalobos  路  3Comments

Juraj-Masiar picture Juraj-Masiar  路  5Comments

Juraj-Masiar picture Juraj-Masiar  路  6Comments