Addons-frontend: Dotted line border still present on desktop and android

[ioanarusiczki]

Part of https://github.com/mozilla/addons-frontend/issues/7298

STR:

1. On desktop load AMO dev login and click the username on the upper right side of the screen.
2. On android load AMO dev navigate away from homepage then tap the logo.

Expected result:
No display issues.

Actual result:
A white rectangle is present.

Notes:
This issue is reproducible on AMO dev and AMO stage with FF64 (Win10) and Android 8.0
The desktop issue is also reproducible with Chrome and Edge.

desktop

android

[willdurand]

⚠️ when fixing this, please make sure keyboard navigation (accessibility) still works.

[suhailsinghbains]

Hi, can I please work on this bug?

[willdurand]

@suhailsinghbains yep

[suhailsinghbains]

I tried to remove the outline attribute, but 0 does not work, still working on it :)

0: warning when fixing this, please make sure keyboard navigation (accessibility) still works.

[ioanarusiczki]

@willdurand

The dotted lines are no longer visible on desktop (win10). - FF65

But on Android (8.0) it is still displayed - FF65

I think we should reopen the issue.

[willdurand]

I think we should reopen the issue.

no, I think it's fine.

[ioanarusiczki]

@willdurand

• I checked the keyboard navigation and did not see any changes. The More menu won't be highlighted while navigation but can be opened. - verified on both AMO dev and AMO prod

• then the android issue stays as it is, while testing I've noticed it is reproducible when making a search too. When changing the sorting by, the add-on type or operating system. Perhaps if I check further I can find more of it but it's a minor ux issue which doesn't bother anyone too much.

[willdurand]

This is a browser default theme and honestly, I don't see the point of hiding it everywhere. I was keen to fix the homepage for Android, but we won't fix everything because that does not really make sense to me. I am thinking about reverting this patch now and wontfix'ing this issue because it is a lot of work/noise for a very little value.

[ioanarusiczki]

@willdurand Well the desktop problem was fixed. Let's just leave this as it is now.