Addons-frontend: 'Add to Firefox' button looks inactive on Search Tool details page

[AlexandraMoga]

Steps to reproduce:

1. Go to AMO homepage and from the More... menu select Search Tools
2. Pick an option from the listed results to see its details page (i.e. https://addons-dev.allizom.org/en-US/firefox/addon/3-maps/)
3. Reload the page
4. Observe the 'Add to Firefox' button displayed on the Search tool details page

Expected result:
The Add to Firefox button is active and blue colored

Actual result:
The Add to Firefox button is grayed out and appears inactive on hover

Notes: when clicked, the button will trigger the installation process and the search plugin is added to the browser Search bar
Reproduced on AMO -dev and stage with FF57 (Win10)

[muffinresearch]

FWIW: On the first time loading I briefly see a "Your browser is not compatible with search plugins" which disappears on-load.

[muffinresearch]

@AlexandraMoga are there similar examples to this in production?

[ValentinaPC]

@muffinresearch

FWIW: On the first time loading I briefly see a "Your browser is not compatible with search plugins" which disappears on-load.

That was tracked in: https://github.com/mozilla/addons-frontend/issues/2412

[AlexandraMoga]

are there similar examples to this in production?

The behavior in production is similar to #2412

[ValentinaPC]

Today, the initial issue is happening in prod.
Example:
https://addons.mozilla.org/en-US/firefox/addon/youtube-10423/

Screenshot:

Also, as Alexandra mentioned in her notes, search tool can be installed.

[tofumatt]

The button is disabled but (due to a possibly different bug!) it seems search tools are still installable on a click.

That said, this is a bit strange because running the same code on production (tag 2017.12.07-1) locally and running master locally the button is enabled. It seems to only happen on prod? Very weird...

[tofumatt]

Actually, I had disableSSR: true on in my config. Server side rendering seems to set the install button state as off/incompatible.

[ValentinaPC]

The button is disabled but (due to a possibly different bug!) it seems search tools are still installable on a click.

Yes. As Alexandra (and I), observed.

[tofumatt]

Sorry about that! I just skimmed the issue. My bad! 🤭

[davidhedlund]

@jvillalobos Said:

I can reproduce the issue:

1. Go to https://addons.mozilla.org/en-US/firefox/search-tools/
2. Click on the Booking.com entry.

Result: the button has some transparency, but still allows installation (for me).

Oddly, if I go to AMO directly and search for "booking.com", I can find the same listing and the button looks right. So, it may have to do with the transition from old to new front end that causes the bug.

[AlexandraMoga]

Maybe we should up the priority for this issue as well, considering that when #5447 it was marked a s a p1.

[willdurand]

@AlexandraMoga isn't it the exact same issue as in #5447? It is a shame that we missed that one..

[willdurand]

ah I saw your comment in the other issue, it is indeed a duplicate.

[kumar303]

The STR in this doesn't make it a dupe of https://github.com/mozilla/addons-frontend/issues/5447 but the comment thread here suggests that you were talking about the same thing. I updated the STR to include the step Reload the page which is necessary to reproduce the bug. Let me know if that's not what you intended.

[ioanarusiczki]

Verified fixed on AMO dev with FF61(Win10&Android 8.0).