Addons-frontend: Website header is untranslatable

[piotrdrag]

Describe the problem and steps to reproduce it:

What happened?

“Firefox Add-ons” is in English on https://addons.mozilla.org/pl/firefox/.

What did you expect to happen?

“Firefox Add-ons” in Polish on https://addons.mozilla.org/pl/firefox/.

Anything else we should know?

CCing @peiying2

[willdurand]

Hi @piotrdrag, the header is actually a brand and therefore has no translation or RTL equivalent. The only translation key you have is "visually hidden" but what you see is an image (logo + text).

[tofumatt]

This seems like an issue a few people have run into and does feel like a bug. Maybe we should be translating this? cc @pwalm

• Matt (Sent from mobile)

On 16 Nov 2017, at 13:48, Piotr Drąg [e-mail] wrote:

Describe the problem and steps to reproduce it:

What happened?

“Firefox Add-ons” is in English on https://addons.mozilla.org/pl/firefox/.

What did you expect to happen?

“Firefox Add-ons” in Polish on https://addons.mozilla.org/pl/firefox/.

Anything else we should know?

CCing @peiying2

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[muffinresearch]

FWIW: the heading is translated behind the scenes as a text alternative, it's just not visually translated.

[muffinresearch]

This is also consistent with other brand usage elsewhere e.g the Thunderbird site in AR.

[tofumatt]

It’s consistent with other sites but I still think it’s wrong/unexpected :-)

It’s more “brand-consistent” I guess, but when it’s the only “English” (and sometimes ASCII) text on screen it feels off.

[piotrdrag]

I wouldn’t equate a proper name like Thunderbird to a descriptive name like “Firefox Add-ons”. I believe the latter should be localized, just like we localize Firefox Account.

[eviljeff]

Fwiw, we translated 'Add-ons' on the legacy site. Product names, like Firefox, weren't translated.

[peiying2]

Brand names, such as Mozilla, Firefox, Pocket are not translated, per current branding guidance. Add-ons is a product name, can be translated, and has been. If this is an image, then, it will be very difficult (remember Marketplace). If it is hard-coded, we should change it so it is localizable.

[piotrdrag]

If this is an image, then, it will be very difficult (remember Marketplace). If it is hard-coded, we should change it so it is localizable.

A week ago it was localizable. :)

[kumar303]

A week ago it was localizable. :)

That's because it did not follow the Photon brand guidance, which was a mistake. The change request was in https://github.com/mozilla/addons-frontend/issues/3763

[muffinresearch]

I mentioned this to @jvillalobos and there's some upcoming discussions re: branding. It'll make sense to hold off making any changes here until those are concluded.

[pwalm]

A week ago it was localizable. :)

Yeah, that was my fault. We should have been implementing the wordmark from the get-go.