Adaptivecards: [iOS][Input Evolution] [input validation error messages enabled on the card sent by bot]

Created on 28 Sep 2020  路  9Comments  路  Source: microsoft/AdaptiveCards

Platform

What platform is your issue or question related to?

  • iOS

Author or host

Host - Teams iOS Client

Version of SDK

SDK 2.1.0 (Adaptive card v1.3)

Details

When card is sent by the bot for the first time then error messages are enabled by default and are not visible completely.

Also, an unknown string "Error Massage" is added for inputs even if that is not present in the card JSON. Seems like SDK is picking it up from the inputLabelView.xib and then, adding it to the card view.

PFA screenshots and cardJson for both scenarios mentioned above:
image
image
cardJson1.txt
cardJson2.txt

AdaptiveCards v20.10 Area-Inconsistency Bug Msft-TeamsMobile MsftTeams-Integration Platform-iOS Priority-Now Status-Fixed Triage-Approved for Fix

Most helpful comment

@sowrabh-msft / @jyoti-ms could you please take a look at @jwoo-msft 's explanation above, see if it helps ? Thanks

All 9 comments

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@shalinijoshi19 @dclaux @jwoo-msft We are facing this issue as we are upgrading to the latest SDK in Teams. Can you please triage and let us know how we can work around this.
FYI: @sowrabh-msft @VikrantSingh01

Hi @jyoti-ms,

I tried your payload, and it is not reproducible on the sample app. The logic for the visibility of the error message is straightforward. The message is hidden initially, When send event is triggered, the validation logic happens, then the visibility will get changed if necessary.

I would suggest checking first that send event of ACRAggregateTarget was not triggered when the card is received. I would also check initInputLabelView of ACRInputLabelView to ensure that logic is correctly followed in the custom renderers.

Since the AdaptiveCard view is squeezed, I would say send or validate was somehow triggered because if the card initially had its subviews not hidden, your TableView would know how tall the AdaptiveCard view is, and would not squeeze the AdaptiveCard view.

Hi @jyoti-ms. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@closing, as this is resolved.

@sowrabh-msft / @jyoti-ms could you please take a look at @jwoo-msft 's explanation above, see if it helps ? Thanks

@jwoo-msft As we have discussed, you are going to update the "hidden" prop in InputLabelView.xib in this month's release?
The fix that we tried is just a temporary one to unblock ourselves for testing and we are using cocoa pods approach to update the framework so we can't replace binaries (.nib files).

@shalinijoshi19 @jwoo-msft - In addition, in the screenshot below the string "My Error Massage" seems to be coming from the SDK too ( This file You may want to remove this).

Would this string also appear on an inadvertent send or validate call?

94483158-19b8f100-01f8-11eb-9363-b746953b36da

Was this page helpful?
0 / 5 - 0 ratings