Adapt_framework: adapt-contrib-hotgraphic: popup images without 'alt' aren't being hidden

[kirsty-hames]

When inspecting the popup images I've found that aria-hidden="true" is applied initially but then stripped out when that item is the current item in view.

To replicate, inspect an item graphic and then cycle through the item pagination to see the attribute being added and removed.

Issue reported running JAWS in Chrome as without aria-hidden="true", the image filename is read. The issue is global however and I think it's related to the recent a11y api updates ​https://github.com/adaptlearning/adapt-contrib-hotgraphic/commit/f1787079c4fa796df0ab8ba58544e479b5926c5a

[moloko]

looks to me like it may be the selector in hotgraphicPopupView's handleTabs function being a bit _too_ wide in scope

[moloko]

Possibly as simple as just changing it to:

handleTabs() {
  Adapt.a11y.toggleHidden(this.$('.hotgraphic-popup__item:not(.is-active)'), true);
  Adapt.a11y.toggleHidden(this.$('.hotgraphic-popup__item.is-active'), false);
}

??

[kirsty-hames]

I can confirm @moloko's suggestion resolves the issue thanks.