Adapt_framework: adapt-theme-vanilla: assets & templates folder

Created on 9 Jun 2020  路  5Comments  路  Source: adaptlearning/adapt_framework

Just adding a small quality of life change here. I would recommend adding an 'assets' & 'templates' folder to the root of the vanilla theme just to show that these things are free to use for storing your repeated assets as well as the ability to affect the HTML templates. I would wager any new developers would try to modify core instead. @guywillis

Most helpful comment

Agreed Joe. There is a limitation with Git however that stops the implementation of empty folders. There would need to be a hidden file like .keep / .gitignore or a visible README file that's either empty or has a brief explanation as to why there is an empty folder.

All 5 comments

Agreed Joe. There is a limitation with Git however that stops the implementation of empty folders. There would need to be a hidden file like .keep / .gitignore or a visible README file that's either empty or has a brief explanation as to why there is an empty folder.

I like the idea of putting a readme.txt in each folder to explain usage

A readme.md would be formatted and readable on GitHub.

that鈥檚 very true but my thinking behind suggesting .txt was to do with whether people would be more likely to read it on GH or locally. A .txt file is more easily readable locally and, given that it鈥檚 probably only going to need a sentence at most to explain the purpose of the folder, would be just as readable via GH too.

It鈥檚 a minor thing, I just feel that in this instance .txt has a slight advantage. but if you want to go with .md, I don鈥檛 feel that strongly about it!

Nah, I like your rational. Nothing like double click to notepad.exe.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

canstudios-louisem picture canstudios-louisem  路  3Comments

danielstorey picture danielstorey  路  3Comments

simondate picture simondate  路  5Comments

chris-steele picture chris-steele  路  4Comments

kirsty-hames picture kirsty-hames  路  5Comments