Actix-web: Update to std::future::Future futures/0.3

Created on 4 Jul 2019  路  15Comments  路  Source: actix/actix-web

std::future::Future is now in stable with Rust 1.36.0. What are the plans for migration? I think one mayor obstacle is at which point tokio is using them right? Do they already have? i am a little bit out of the loop https://github.com/tokio-rs/tokio/pull/1218

Most helpful comment

I started the work on migrating the actix-net ecosystem, which is needed in order to convert the
actix-web libraries. Work can be seen here: https://github.com/actix/actix-net/issues/45.

All 15 comments

actix-service must be ported first. It does not depend on tokio

How about use tower::Service instead

I tried, it does not work well. Also I don鈥檛 want to depend on external dependency. So no tower

Okey, but can we provide a bridge between actix-service and tower as an optional feature?

There is project in actix-net repo. But I am not interested in that project. I can move it outside so other people can work on it

Seems like a lot's going on now, eg tokio 0.2.0-alpha-1.

Async/Await stable pr is merged in today nightly version, should we start the process to update to std::future::Future

I started the work on migrating the actix-net ecosystem, which is needed in order to convert the
actix-web libraries. Work can be seen here: https://github.com/actix/actix-net/issues/45.

Are there any plans to migrate to tokio 0.2?

The migration has started on actix-net, there's a migration tracking issue there.

I see this issue assigned to the 1.1 milestone. I doubt you can migrate to tokio 0.2 and async-await without breaking changes in the API. Based on that and semantic versioning the next actix-web version should be 2.0, right?

The migration has started on actix-net, there's a migration tracking issue there.

We're going to need some help starting with the actix-service folder in actix-net.

See https://github.com/actix/actix-net/pull/57.

If you'd like to help, please converse in that PR and and/or if you have work open a PR into actix-net/std-future branch.

We should be able to get this done pretty quickly just need some minds to start talking it through.

Just landed in actix-net https://github.com/actix/actix-net/pull/64

Fantastic work, @fafhrd91!

the next actix-web version should be 2.0, right?

I'm all for that, people that need futures 0.1 and fixes can then still stay on 1.X
I think a 2.0 release would also reflect the amount of work that went into the async/await port and the changes when writing async stuff for actix-web.
(In other words: please don't repeat the 1.0.2 breaking changes.)

tracking issue #1166

Was this page helpful?
0 / 5 - 0 ratings

Related issues

fafhrd91 picture fafhrd91  路  5Comments

djc picture djc  路  3Comments

yoshrc picture yoshrc  路  5Comments

mcelkys picture mcelkys  路  4Comments

zhaobingss picture zhaobingss  路  4Comments