Actix-web: Lack of WebSocket continuation support

Created on 14 Jun 2019  路  2Comments  路  Source: actix/actix-web

This is already noted in the code, but actix-web's WebSocket implementation doesn't support WebSocket Continuations.

It turns out that Chrome uses continuations fairly arbitrarily, regardless of message size. This results in it being pretty hard to use actix-web's WebSockets on standard websites, since actix will just close the WS whenever Chrome decides to use a continuation.

Most helpful comment

I just discovered https://github.com/actix/actix-web/pull/530, a PR from 8+ months ago which fixes this but never got merged. :sweat_smile:

@fafhrd91 I see you approved the PR back when it was submitted. Is there any chance you (or someone of your choice) could port it to 1.0 and merge it? The original author of the PR seems to no longer be available.

All 2 comments

I just discovered https://github.com/actix/actix-web/pull/530, a PR from 8+ months ago which fixes this but never got merged. :sweat_smile:

@fafhrd91 I see you approved the PR back when it was submitted. Is there any chance you (or someone of your choice) could port it to 1.0 and merge it? The original author of the PR seems to no longer be available.

ws continutation is added to master

Was this page helpful?
0 / 5 - 0 ratings

Related issues

icommit picture icommit  路  3Comments

Eilie picture Eilie  路  5Comments

volfco picture volfco  路  4Comments

kocoten1992 picture kocoten1992  路  3Comments

Dadibom picture Dadibom  路  4Comments