Ace3: Missing grenade impact sounds

[Gwynblade]

Arma 3 Version: 1.92 (stable)
CBA Version: 3.11.2 (stable)
ACE3 Version: 3.12.6 (stable)

Mods:

- CBA_A3
- ace

Description:
With ACE running, you get grenade pin pull sounds, but no grenade impact sounds (when grenade hits the floor or wall for example).
With no mods loaded, you get grenade impact sounds, but no pull pin sounds (since ACE adds that).

Steps to reproduce:
https://www.youtube.com/watch?v=vbAb25obxCM&feature=youtu.be
Comparison with, and without ACE

Where did the issue occur?
Everywhere

[jonpas]

Are we not spawning the correct projectile? :thinking:

@PabstMirror clues?

[commy2]

There may be a difference between an engine created and createVehicle'd ammo object.
This is not about advanced throwing, right? So it should be the engine created projectile anyway.

[jonpas]

I can't tell from the video if it's using advanced throwing or not. @Gwynblade ?

4648 would have removed those sounds, but that was never merged.

[Gwynblade]

I just tested to be sure, and it's the same with normal and advanced throws.

Could this be it: https://github.com/acemod/ACE3/pull/3923 ?
It mentions something about removing clinking sounds.

[jonpas]

That could be it, it sets:

impactGroundSoft[] = {};

[jonpas]

@commy2 you commented on that https://github.com/acemod/ACE3/pull/3923#discussion_r66970449, any clue why that was done?

PR does say:

Remove ridiculous clinking sound when grenades spawn.

Maybe no one realized it also removes impact sounds? :thinking:

[commy2]

I just commented that instead of setting soundImpactSoft1[] to 20 to {"",1,1,1}, one could just empty the array that references all these array tokens. Which is true.

Probably should just delete that config entry and restore the "ridiculous" vanilla sounds. I never had a problem with them.

[commy2]

Can't have impact sound that does not play on projectile creation, which sounds dumb when throwing the grenade.