Accelerated-mobile-pages: Webp as featured image is not working in the single posts
https://wordpress.org/support/topic/amp-pages-dont-show-webp-images-format/#post-11384580
Tested on localhost as well
ahmedkaludi
All 25 comments
Why there is a need for another get_post_thumbnail_id when it is already getting called in class-amp-post-template.php?
Instead of adding extra code, can we do it with the existing one?
MARQAS
on 9 Apr 2019
We cannot add the get_post_thumbnail_id of the class-amp-post-template.php because this is only working for normal featured images and not WebP format.
Zabi09
on 16 Apr 2019
Try to wrap it in a function
MARQAS
on 18 Apr 2019
Notice: Undefined variable: post_id in O:\wamp64\www\weekly\wp-content\plugins\accelerated-mobile-pages\templates\features.php on line聽7806
MARQAS
on 18 Apr 2019
* Review *
[x] Kaleem
[ ] Imran
pegazee
on 23 Apr 2019
Issue not replicated on my local server.
@ansaritalha what about you?
beingsmart3
on 23 Apr 2019
escaping missing
MohammedKaludi
on 2 May 2019
also, this is a very nice suggestion from @MARQAS https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/2996#issuecomment-481124849
How can we implement this.
MohammedKaludi
on 2 May 2019
The WebP images don't have a width and height and due to that the image sanitizer is striping it and So I have discussed with @MARQAS and created a function for that.
Zabi09
on 16 May 2019
Incorrect escaping
MohammedKaludi
on 16 May 2019
Causing error when featured image and the content image is the same ( other than swift)
MARQAS
on 16 May 2019
Why removed scrset and alt from the code?
MohammedKaludi
on 18 May 2019
Due to debug warnings I removed the scrset and alt because the webP images were not giving any scrset and alt attributes
Zabi09
on 18 May 2019
While merging this ticket in master, make sure this code is available or not: https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/fb51a2794b2638e679d6d6ab8da8b6b0d184139a#diff-6aa5512f7dd8d5ce60fc97b0f340912cR7807
pegazee
on 25 May 2019
Not working in the single posts of all the designs and working only on swift.
Rkroy
on 29 May 2019
Featured image is repeating when Featured Image from The Content or Featured Image from Custom Fields option is enabled.
MARQAS
on 11 Jun 2019
It is still repeating.
Add a Featured Image and check in Design1,2 and 3
MARQAS
on 14 Jun 2019
ready to merge.
MohammedKaludi
on 14 Jun 2019
Pushed in 0.9.97.58
MohammedKaludi
on 15 Jun 2019
Our custom theme's amp (single) template calls amp_featured_image() and in doing so seems to generate two featured images. This wasn't occurring before so I'm trying to understand if we need to adjust our settings or change our template.
The above line seems to be where the duplication occurs best I can tell.
I just updated to 0.9.97.58 which is when the problem started.
jeremymoore
on 18 Jun 2019
Our custom theme's amp (single) template calls
amp_featured_image()and in doing so seems to generate two featured images. This wasn't occurring before so I'm trying to understand if we need to adjust our settings or change our template.The above line seems to be where the duplication occurs best I can tell.
I just updated to 0.9.97.58 which is when the problem started.
Thank you @jeremymoore Will check it and will take necessary action.
MohammedKaludi
on 18 Jun 2019
@Zabi09 Check this issue in the first thing in the morning.
MohammedKaludi
on 18 Jun 2019
Thanks, for now, we'll bump back down to the previous version. Thanks!
jeremymoore
on 18 Jun 2019
Ready to merge.
MohammedKaludi
on 19 Jun 2019
Pushed in 0.9.97.59
MohammedKaludi
on 21 Jun 2019
Related issues
chaselivingston
路
5Comments
ghost
路
6Comments
TMsravan
路
3Comments
HaripriyaHari
路
7Comments
shchedrakov
路
3Comments