Absinthe: Introspection compiles but returns invalid schema at runtime if you include a normal object in an input object

[tpbowden]

Environment

• Elixir version (elixir -v): 1.6.1
• Absinthe version (mix deps | grep absinthe): 1.4.7
• Client Framework and version (Relay, Apollo, etc): Any client

Expected behavior

Invalid input objects raise a compile time, or at least a runtime error.

Actual behavior

Schema with invalid input object does not raise any error, but the generated introspection schema is invalid. Different clients fail in different ways. graphql-cli fails like this:

Introspection must provide input type for arguments.

Steps to reproduce

Create an input object like this:

object :my_object do
  field :anything, :string
end

input_object :some_input do
  field :bad, :my_object
end

[benwilson512]

Fixed in master, will backport to 1.4 as well in a patch release

[tpbowden]

Awesome, thanks!

[inaniyants]

Looks like this fix was not backported to 1.4 and the problem is still reproduced.
Probably, this is due to huge difference in this file between two branches:

https://github.com/absinthe-graphql/absinthe/compare/v1.4.13...master#diff-9ee072bcc09698a54f1da79567eaf411R1

@benwilson512 what about applying original fix to 1.4 branch ?

[tcoopman]

I'm also running into this. Any changes of backporting this?

[stueccles]

I ran into this as well on 1.4. Would be good to get this reopened and the fix backported.

[benwilson512]

1.5 is on RC, there will not be any further backports to 1.4 at this point.

On Mon, Jan 20, 2020 at 1:18 PM Stuart Eccles [e-mail]
wrote:

I ran into this as well on 1.4. Would be good to get this reopened and the
fix backported.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/absinthe-graphql/absinthe/issues/507?email_source=notifications&email_token=AAB4QCJ5JWNYVLEPJQXLJMDQ6XTI3A5CNFSM4ER6AN22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJNPASA#issuecomment-576385096,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB4QCKIN7YDBSOTNFZO7E3Q6XTI3ANCNFSM4ER6AN2Q
.

[stueccles]

ok, awesome. Looking forward to getting on 1.5!

On Mon, Jan 20, 2020 at 1:20 PM Ben Wilson [e-mail] wrote:

1.5 is on RC, there will not be any further backports to 1.4 at this point.

On Mon, Jan 20, 2020 at 1:18 PM Stuart Eccles [e-mail]
wrote:

I ran into this as well on 1.4. Would be good to get this reopened and
the
fix backported.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/absinthe-graphql/absinthe/issues/507?email_source=notifications&email_token=AAB4QCJ5JWNYVLEPJQXLJMDQ6XTI3A5CNFSM4ER6AN22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJNPASA#issuecomment-576385096
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAB4QCKIN7YDBSOTNFZO7E3Q6XTI3ANCNFSM4ER6AN2Q

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/absinthe-graphql/absinthe/issues/507?email_source=notifications&email_token=AAAAZ2VL5H6JWS4CDQP2ZKDQ6XTOHA5CNFSM4ER6AN22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJNPDTA#issuecomment-576385484,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAZ2SEBVGPC5C5X4JMZFTQ6XTOHANCNFSM4ER6AN2Q
.