Abp: IOptions<IdentityOptions> doesn't change value when set by ISettingManager

[yinchang0626]

In identity module ,
We have a AbpIdentityOptionsFactory to create IdentityOptions by abp Settings module.
That is easy to store identityOptions base on tenant or other SettingValueProvider...
but when i set value by ISettingManager( setting-management module),
identityOptions doesn't know the value is changed, below code:

  var oldValue = IdentityOptions.Value.Password.RequiredLength;
  await settingManager.SetGlobalAsync(IdentitySettingNames.Password.RequiredLength, newValue);
  var updatedValue = IdentityOptions.Value.Password.RequiredLength;

updatedValue should be newValue but it is oldValue.
@hikalkan :
could you tell me how to enhance AbpIdentityOptionsFactory like IOptionsMonitor do .let it can auto change when database(by settingstore) is change.
or is it now enough that , no need to enhance ?

[maliming]

Please see this unit test method.

https://github.com/abpframework/abp/blob/42f37c5ff01ad853a5425d15539d4222cd0dab69/modules/identity/test/Volo.Abp.Identity.Domain.Tests/Volo/Abp/Identity/IdentityOptions_Tests.cs#L32-L48

[yinchang0626]

@maliming
thank for reply.
in that unit test doesn't present this question .
it should be in the same scope to modify value and get value directly like

using (var scope1 = ServiceProvider.CreateScope())
{
    var options = scope1.ServiceProvider.GetRequiredService<IOptions<IdentityOptions>>().Value;
    options.Password.RequiredLength.ShouldBe(6); //Default value
    options.Password.RequiredUniqueChars.ShouldBe(1); //Default value 
    _settingProvider.GetOrNullAsync(IdentitySettingNames.Password.RequiredLength).Returns(Task.FromResult("42"));//====>pretend changed by settingManager
    options.Password.RequiredLength.ShouldBe(42);//=====>error,value is 6
}

in fact
it will be fine if modify value by ISettingManager and get value by(IOptions) is in different scope(different http request).
but you should take care in one request the options value is different with db.
so i hope to enhance it to avoid mistake
and this is my test code

    public class SampleAppService : EpsyAppService, ISampleAppService
    {
        public IOptions<IdentityOptions> IdentityOptions { get; set; }
        public ISettingManager _settingManager { get; set; }
        public Volo.Abp.SettingManagement.ISettingManager settingManager { get; set; }
        public SampleAppService(){}
        public async Task<object> PostIdentity(string newValue)
        {
            var oldValue = IdentityOptions.Value.Password.RequiredLength;
            await settingManager.SetGlobalAsync(IdentitySettingNames.Password.RequiredLength, newValue);
            var updatedValue = IdentityOptions.Value.Password.RequiredLength;
            return Task.FromResult(new { oldValue, newValue, updatedValue });
        }
    }

i use it in SampleController to try it.

[maliming]

This is because IOptions is a singleton. I can't think of any way to enhance it.

[yinchang0626]

i found it ASP.NET Core 2.1 源码学习之 Options[3]:IOptionsMonitor
in this article ,the option can watch file change (appsettings.json).
but i have no idea how to do with abp ISettingManager

[maliming]

@hikalkan What do you think?

[hikalkan]

Options are cached by aspnet core. I don't know if there is a way of invalidating the cache. I should check it deeper.

[hikalkan]

Currently, options are cached only for a single request. Normally you update the settings in a separate request, so you can get the new values in the next request.
I am moving this to the next milestone since it is not urgent and there is no problem in most cases.

For now, you may want to set options after changing the setting, so other services can get the latest setting value.