30-seconds-of-code: Silent type cast not mentioned

[GrosSacASac]

For mapObject

the keys will be cast to String, it should be explained, or at least a warning. The example makes it look like they are stored as numbers.

[skatcat31]

I'm confused on where it looks like they would be stored as numbers versus string coercion?

[fejes713]

@GrosSacASac could you please provide more details regarding this issue?

If this is what bothers you I don't see any problems with it. The output from the 30seconds docs matches the output on the console. While Object keys are indeed only strings their properties could be accessed with numbers too.

JavaScript Engines do perform something called _type coercion_ when trying to access object keys with values other than type String or Symbol. For further info, see MDN docs.

[fejes713]

Hopefully, this helped a bit, if not let's solve this one together 😄

[GrosSacASac]

where the key-value pairs consist of the original value as the key and the mapped value

I would write:
where the key-value pairs consist of the stringified value as the key and the mapped value

[fejes713]

Thanks for clarifying this. @skatcat31 this seems like a solid change - should I modify the function docs?

[skatcat31]

It's a fair clarification for newer programmers(I've met more than a few who think object literals are Maps)

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.