30-seconds-of-code: getURLParameters can be wrote in this way

[RobinZhao00]

const getURLParameters = url => (url.match(/([^?=&]+)(=([^&]*))/g) || [])
.filter(a => a.includes('='))
.map(b => b.split('='))
.reduce((prev, curr) => ({ ...prev, [curr[0]]: curr[1] }), {});

getURLParameters wrote in this way can be easily understood

[skatcat31]

https://developer.mozilla.org/en-US/docs/Web/API/UR

If anything we should just rewrite getURLParameters using the URL class and avoid the regex.

const getURLParameters = url => new URL(url).search
  .slice(1)
  .split('=')
  .reduce((acc, [key, value]) => key && (acc[key] = value, acc) || acc, {})

[RobinZhao00]

https://developer.mozilla.org/en-US/docs/Web/API/UR

If anything we should just rewrite getURLParameters using the URL class and avoid the regex.

const getURLParameters = url => new URL(url).search
  .slice(1)
  .split('=')
  .reduce((acc, [key, value]) => key && (acc[key] = value, acc) || acc, {})

[RobinZhao00]

https://developer.mozilla.org/en-US/docs/Web/API/UR
If anything we should just rewrite getURLParameters using the URL class and avoid the regex.

const getURLParameters = url => new URL(url).search
  .slice(1)
  .split('=')
  .reduce((acc, [key, value]) => key && (acc[key] = value, acc) || acc, {})

const getURLParameters = url => new URL(url)
      .search.slice(1)
      .split('&')
      .map(itm => itm.split('='))
      .reduce((prev,[ key, value]) => ({ ...prev, [key]: value}), {});

[RobinZhao00]

URL class and avoid the regex
A summary :

// 通过创建URL对象获取查询参数
// get search by URL class
const getURLParameters = url => new URL(url).search
  .slice(1)
  .split('&')
  .map(itm => itm.split('='))
  .reduce((prev, [key, value]) => ({ ...prev, [key]: value }), {});

// 通过正则获取查询参数
// get search by regex
const getURLParameters = url => (url.match(/([^?=&]+)(=([^&]*))/g) || [])
  .filter(a => a.includes('='))
  .map(b => b.split('='))
  .reduce((prev, [key, value]) => ({ ...prev, [key]: value }), {});

[Chalarangelo]

https://developer.mozilla.org/en-US/docs/Web/API/UR

If anything we should just rewrite getURLParameters using the URL class and avoid the regex.

const getURLParameters = url => new URL(url).search
  .slice(1)
  .split('=')
  .reduce((acc, [key, value]) => key && (acc[key] = value, acc) || acc, {})

This is not a viable option, as the URL API is not available in Node.js. The snippet might be used in a server-side context, not only a client-side one (e.g. parsing a request URL in Express), so this would be a breaking change.

[Chalarangelo]

Based on this perf, the existing version performs better than the suggested change both on Chrome and Firefox. Therefore, I am closing the issue as the readability improvements to the snippet are negligible.

[skatcat31]

@Chalarangelo https://nodejs.org/docs/latest-v4.x/api/url.html#url_url and if you scroll down search is available. This has been available since NodeJS 4LTS

[skatcat31]

I did however manage to delete the part that made it actually work in an edit... go me -.-

const getURLParameters = url => new URL(url).search
  .slice(1)
  .split('&')
  .map(s =>s.split('='))
  .reduce((acc, [key, value]) => key && (acc[key] = value, acc) || acc, {})

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.